ofxparser icon indicating copy to clipboard operation
ofxparser copied to clipboard

Published 20 hours ago • verified publisher icon asgrim

Enhance OFX Parser

Open beroso opened this issue 7 years ago • 4 comments

Fix #34

beroso avatar Feb 14 '18 01:02 beroso

+1.

In https://github.com/mkopinsky/ofxparser/commit/f44df3aa756ddbccdcbcb29eaea561be4b410194 I added a unit test/fixture for a oneline OFX file which does include some line breaks, and this PR passed that with no problem. (I also tested with the actual QFX file from Ally Bank, which also passed.)

mkopinsky avatar Feb 14 '18 13:02 mkopinsky

I'm glad to hear that, @mkopinsky, I will include your OFX in this PR. Thank you for your feedback.

beroso avatar Feb 14 '18 14:02 beroso

Nice improvement, thank you @berosoboy - just a couple of changes please as above :)

asgrim avatar Feb 14 '18 15:02 asgrim

Sorry for the delay on this one, there seems to be a conflict - could you take a look please and poke me when resolved? Thanks!

asgrim avatar Jan 18 '19 08:01 asgrim