ofxparser icon indicating copy to clipboard operation
ofxparser copied to clipboard

Published 20 hours ago • verified publisher icon asgrim

Amount parse enhancement

Open beroso opened this issue 7 years ago • 4 comments

Fix #19

beroso avatar Jan 24 '18 20:01 beroso

Travis CI build is failing because of this check:

'100' => ['100', 1.0], // @todo this is weird behaviour, should not really expect this

Could you check if it is suitable?

beroso avatar Jan 24 '18 21:01 beroso

At the moment, can't merge this as it would be a BC break (hence why that test case exists). Yes, it's stupid behaviour but some may rely on it, unfortunately so I can't change until next major release. Otherwise, will review this in time, but as it's a BC break don't hold your breath ;)

asgrim avatar Jan 24 '18 21:01 asgrim

Understood. What are your plans to the next release? I will be glad to help

beroso avatar Jan 24 '18 21:01 beroso

Currently, to find time to refactor for better quality, more tests, fix the stupid things that don't make sense and make a minimum PHP 7.1 or 7.2 probably :+1:

asgrim avatar Jan 29 '18 12:01 asgrim