Anders Schack-Mulligen

Results 64 comments of Anders Schack-Mulligen
trafficstars

As for the path in `FakeSource`, I'll just echo what Edoardo wrote: We generally assume that code exists for a reason and therefore assume that `FakeSource` can be called in...

Fixed by https://github.com/github/codeql/pull/10416

Ping @ginsbach : Parameterised modules in here.

> How long does this step usually take on your end? Several minutes for the large cases.

I have some local changes that will add some progress logging, but that's blocked on https://github.com/github/vscode-codeql/issues/1459. You should make sure that you're using multiple threads to calculate the paths -...

(Or I guess you could check your CPU usage to gauge the number of computing threads)

> When I try to replicate the issue by re-opening of the results view afterwards it also seems to hang. Reopening a multi-GB sarif file does take a little bit...

> @aschackmull could you take a look at the dataflow logic in this query, and see if something can be improved? There is certainly some very unusual flow going on...

> Seems to be some memory pressure (lots of instances of "pausing/unpausing evaluation") within some of the dataflow stages. That typically just means that the flow you're trying to calculate...

This is not targeting experimental, so will need a thorough FP evaluation before merge.