Anders Schack-Mulligen
Anders Schack-Mulligen
Also, needs a docs review at some point.
> Will this also fix #3710? Excellent question. I am indeed introducing dedicated data flow nodes corresponding to variable declarations in catch clauses along with (among others) the outgoing edges...
> #3710 was originally created in response to the "Step 3: Errors and Exceptions" part of https://securitylab.github.com/ctf/codeql-and-chill/. > > ```java > try { > parse(tainted); > } catch (Exception e)...
> Outputting logs in this way minimizes the chance that multiple commands will have output interleaved. To be fair, though, I don't know how often this really happens. I don't...
LGTM. Let's get a doc review.
> @aschackmull I introduced a new parameterized module [here](https://github.com/github/codeql/pull/10177/files#diff-38978229f15815dd860ec9f3696f469770f85b8082736b808072ef64be18a834R15-R43). If you have the chance to review it, let me know if something doesn't look right. Had a quick look -...
Looks like there's a performance problem somewhere.
Java: `getNumberOfCommentLines` and `getNumberOfLinesOfCode` should only exist for supported classes
Thank you for raising this - this definitely sounds like something to improve. We'll try to have a look when time permits.
Why is this relevant? Doesn't this just indicate that you have a poor join-order somewhere else?
The fix only affects one query, so you could have just selected that in dca.