Alexander Sashnov

Results 24 comments of Alexander Sashnov

Testing notes: ![Screenshot from 2022-02-20 16-24-42](https://user-images.githubusercontent.com/5078434/154836289-1f327dc9-1827-4fdc-96a6-8e262afcb0a5.png) In Search mode 'Search' is on the left, but this only because 'Search' is in Enlish: ![Screenshot from 2022-02-20 16-33-11](https://user-images.githubusercontent.com/5078434/154836629-b3cff4b5-8a7e-4c95-b951-a0d17e1b564f.png) When run with 'ar'...

@kelson42 > @asashnov Thx for your PR, this is a lot better, but IMO there is problem with the alignment of content within the searchbox itself, see my comment at...

`-reverse` changes the layout, but keeps menu texts in English. So with just `-reverse` option we cannot see fully mirrored controls because strings in English continue to be aligned left...

This is why we need to connect the signal every time: From Qt sources, qlineedit.cpp: ```c void QLineEdit::focusInEvent(QFocusEvent *e) ... if (d->control->completer()) { d->control->completer()->setWidget(this); QObject::connect(d->control->completer(), SIGNAL(activated(QString)), this, SLOT(setText(QString))); ... void...

This is a completely new fix, not based on the previous changes I made. This change is trying to be minimal. And it use reliable way of distinguishing between a...

rebased on current master

rebased on the current master. @mgautierfr Strange indeed that in your experience LANG=ar didn't have the effect. I specified LANG value in QtCreator's program run environment: ![Screenshot from 2022-06-15 01-40-53](https://user-images.githubusercontent.com/5078434/173664947-ac424362-6bae-4e5d-9b60-900bd375e2d5.png)...

@kelson42 Which icons did you ment in your previous comment? Icons inside tab headers (close button and the content web page icon) are reverted- that's right, this is a standard...

Qt manual says (https://doc.qt.io/qt-5/qtquick-positioning-righttoleft.html): > The general rule of thumb is that content (like photos, videos and maps) is not mirrored, but positioning of the content (like application layouts and...

Got it! It's a kind of bookmarks. So maybe it would be more expected by users to replace it with a star (☆) icons (favorites). Then the placeholder text should...