kiwix-desktop icon indicating copy to clipboard operation
kiwix-desktop copied to clipboard

Usability: unclear toggle button in the Search box

Open asashnov opened this issue 3 years ago • 8 comments

Found in current 'master' (0183274f)

Screenshot from 2021-02-26 01-24-02

Screenshot from 2021-02-26 01-24-09

'Glasses' icon does not have a tooltip. Also, a placeholder text in Search bar repeats the current page title.

It would be more logical (and useful) if the placeholder text in Search explains which kind of search will be performed, for example:

When the button is on, placeholder says:

Type here to search in all the articles of the current document

When the button is off, the placeholder says:

Type here to search in the current page only

As I don't know the use of this toggle button, the texts above are just an examples, they should be written to really describe the current search tool state.

asashnov avatar Feb 25 '21 18:02 asashnov

Got it! It's a kind of bookmarks. So maybe it would be more expected by users to replace it with a star (☆) icons (favorites).

Then the placeholder text should always say:

Type here to search in the entire 'Wikipedia' storage

'Wikipedia' is the title of current .zim as we see it in the Library page.

asashnov avatar Feb 25 '21 18:02 asashnov

@asashnov I believe, like you suggested, the best thing to do current,y is to add the tooltips:

  • "Add to the reading list"
  • "Remove from the reading list"

kelson42 avatar Feb 25 '21 18:02 kelson42

@asashnov I'm not eager to change the behaviour of printing current page in the searchbox. This has a decision which has been carefully taken if I correctly remember. Same for the logo choice. Maybe @schoenbaechler can give a bit more background explanation why it has been done that way.

@asashnov If you could quickly add the tooltip, this would be great.

kelson42 avatar Feb 26 '21 08:02 kelson42

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Jun 02 '21 16:06 stale[bot]

@asashnov @Popolechien I would like to move on with this ticket. I believe the best thing to do is:

  • Replace the current icon set with the standard « bookmark star »
  • Add the tooltip

OK for both of you?

kelson42 avatar Dec 04 '21 04:12 kelson42

fine by me!

Popolechien avatar Dec 04 '21 08:12 Popolechien

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Jun 13 '22 03:06 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

stale[bot] avatar Aug 14 '22 01:08 stale[bot]

I made a PR to solve this issue. A few example screenshots below:

Screenshot_1 Screenshot_2

sgourdas avatar Mar 21 '24 16:03 sgourdas