kiwix-desktop
kiwix-desktop copied to clipboard
Usability: unclear toggle button in the Search box
Found in current 'master' (0183274f)
'Glasses' icon does not have a tooltip. Also, a placeholder text in Search bar repeats the current page title.
It would be more logical (and useful) if the placeholder text in Search explains which kind of search will be performed, for example:
When the button is on, placeholder says:
Type here to search in all the articles of the current document
When the button is off, the placeholder says:
Type here to search in the current page only
As I don't know the use of this toggle button, the texts above are just an examples, they should be written to really describe the current search tool state.
Got it! It's a kind of bookmarks. So maybe it would be more expected by users to replace it with a star (☆) icons (favorites).
Then the placeholder text should always say:
Type here to search in the entire 'Wikipedia' storage
'Wikipedia' is the title of current .zim as we see it in the Library page.
@asashnov I believe, like you suggested, the best thing to do current,y is to add the tooltips:
- "Add to the reading list"
- "Remove from the reading list"
@asashnov I'm not eager to change the behaviour of printing current page in the searchbox. This has a decision which has been carefully taken if I correctly remember. Same for the logo choice. Maybe @schoenbaechler can give a bit more background explanation why it has been done that way.
@asashnov If you could quickly add the tooltip, this would be great.
This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.
@asashnov @Popolechien I would like to move on with this ticket. I believe the best thing to do is:
- Replace the current icon set with the standard « bookmark star »
- Add the tooltip
OK for both of you?
fine by me!
This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.
I made a PR to solve this issue. A few example screenshots below: