Asa Baylus

Results 12 comments of Asa Baylus

This is a pretty cool feature to add. I love it. Please feel free to submit a PR. I quite busy so it might take some time before I get...

I like the idea. It may take a while before I get to it, but PRs are very welcome.

Per @jcf3 thanks for the tip, looking at: https://www.w3.org/TR/wai-aria-practices/examples/combobox/aria1.0pattern/combobox-autocomplete-list.html

@iddan can you describe what you are testing? The use of this should be optional within the command functions

Have you considered passing a noop function as commands then using onSelect to execute your function?

Yes, you'd be using onSelect much like the browser native drop down list box and matching on the returned object so that your function could be executed. For context, I've...

@iddan I've got a few other enhancements to get to first but I'm open to a pull request

Theres a few other enhancements ahead of this one but feel free to open a PR, otherwise I'll get around to it.

@pcgeek86 it's been a while but I could use some feedback, please have a look at my VS Code Theme PR https://github.com/asabaylus/react-command-palette/pull/537 and try out http://localhost:6006/?path=/story/command-palette--vscode-theme

@nitishMehrotra please feel free to open a PR