Arvid Norberg

Results 1037 comments of Arvid Norberg

I would approve a PR that removes the memset and adds the static_assert I suggested earlier. nut I don’t have privileges to merge

I do not think this proposed patch is a good solution to the GCC warning. The warning is right, this patch just silences it instead of fixing the code.

Do you have any benchmarks on how well these compression algorithms work on various kinds of work-loads? It would be interesting to have some idea of how helpful these compression...

data is transferred in 16kiB blocks, that would be the natural level to apply compression to. Consider you may have some peers not supporting the extension, you want to be...

in my mind, the best solution would just be for libutp to not define any of these typedefs, but to just use `std::int64_t` etc.

this has been addressed upstream

yeah, the mailing list used to be open, but something happened a few years ago and nobody at BitTorrent Inc. has managed to figure out (or have had enough incentive)...

looks good overall. The previous version did not attempt to describe how clients would use this (at was expected to be inferred). Your update goes so far to say a...

(sorry for taking so long to respond). Is there a compelling reason to add a dependency on libtorrent just for that one file? my long term plan/hope is to separate...

Here's my recollection (from memory). perhaps @xercesblue can be convinced to fill in some details. The data layer encryption is AES. Each 16 kiB chunk/block is encrypted individually. The low...