Arvid Norberg comments

Results 1037 comments of


                                            Arvid Norberg

CHIA-208 Move NPCResult to chia types

I agree that `cost_calculator` is not a good module name for this type. However, I would go farther and say `NPCResult` isn't a good name for this type. it's a...

Remove (unused) debug method in SpendBundle so we can decouple from chia.wallet.util

@Quexington expressed interest in keeping this to be able to print a spend bundle from the debugger. I'm kind of hoping there is a better solution to this than to...

[CHIA-598] Create check for a virtual project structure

I think another approach to make this more incremental would be to start with few projects, and split them as we go. e.g. we could start with just "core", "full_node"...

[Bug] chia plotnft get_login_link generates wrong URL when farming to multiple pools

@whosrdaddy in your `config.yml` there should be a section `pool:` and it should contain a section called `pool_list:`. In your case, I would expect this list to have two items,...

update compute_additions_with_cost() to use run_puzzle()

it seems we have a lot of tests exercising this function with invalid puzzles, and still expect to get the created coins returned..

update compute_additions_with_cost() to use run_puzzle()

the main challenge with this change is that we run unmatched offers to find their output coins, even though they are invalid. This change will just fail the whole puzzle...

[Bug] wallet update states and subscribes to a HUGE number of already spent coins on restart

the fundamental problem is that the wallet doesn't remember how far we synced the wallet in the last session. Every time we start the wallet we sync from scratch. This...

Introduce get_unspent_lineage_ids_for_puzzle_hash to use in the singleton fast forward feature

This PR can be closed, as it has been subsumed by https://github.com/Chia-Network/chia-blockchain/pull/16919 right?

improve BlockHeightMap flush

I'm not entirely convinced that this is a step in the right direction. I imagine the theory is that something threw an exception after the `height-to-hash` file was written, but...

server: Drop `ChiaServer.validate_broadcast_message_type`

did you run into a problem with this check?