clvm_rs icon indicating copy to clipboard operation
clvm_rs copied to clipboard

support building with libgmp as well as num-bigint

Open arvidn opened this issue 4 years ago • 2 comments

the mpz_import and mpz_export functions are quite a bit slower than the num-bigint counterparts, so this slows down the benchmarks somewhat.

The rationale for this is:

  1. use more main-stream code, with lower security risks
  2. (possibly) use the same instance of libgmp as we already use in chiavdf and bls-signatures

arvidn avatar Nov 12 '21 11:11 arvidn

interestingly, there seems to be a rule preventing building the FFI layer on windows: https://github.com/Chia-Network/clvm_rs/runs/4189087870?check_suite_focus=true#step:7:104

That probably has to be addressed before we can try to get MPIR working.

arvidn avatar Nov 12 '21 11:11 arvidn

'This PR has been flagged as stale due to no activity for over 60 days. It will not be automatically closed, but it has been given a stale-pr label and should be manually reviewed.'

github-actions[bot] avatar Mar 15 '22 11:03 github-actions[bot]