Arvid Norberg

Results 1037 comments of Arvid Norberg

I think it's fine to disable more tests as well, for now. Or are all the tests passing now?

I see. the tests linking dynamically appear to not find the DLL (so maybe those tests could be disabled). All tests using python seem to fail because `python3` doesn't seem...

with python version being yet another dimension in this test matrix, I think it makes even *more* sense to remove `py` and `nopy` as a dimension. just always build python...

there are still failing tests, right? My impression is it's not ready to merge right now.

I think that invariant check is probably wrong. It's clear that the torrent is just about to not be in checking mode anymore. I imagine the torrent state is updated...

you could try to build with invariant checks disabled, or comment out that specific invariant check that's failing to see. Also, the error should be visible in the debugger (whatever...

I just noticed this stack frame: ``` NativeTorrentExtension::on_pause() ``` Is that part of qbt? That's probably why I haven't been able to reproduce this

Could you (or someone else seeing this having this problem) give this a try? https://github.com/arvidn/libtorrent/pull/4677

The original issue of this ticket appears to be caused by a plugin altering the libtorrent state in one of its callbacks. This is reasonable and expected behavior from a...

thanks for the report. What's really needed for i2p support to stay stable is a test. I think it's kind of a fringe feature still and so it hasn't received...