Arvid Norberg
Arvid Norberg
how come the github actions aren't being executed as part of this PR? is it because it's a draft?
> The libraries appear to all be successfully found, but the linking fails with unresolved symbols for boost-python. > I haven't found a solution for this yet. I seem to...
I don't think it's worth the effort to build and test against python2.
the file `ci.yml`, is that name important, or can it be anything? if it can be anything, I think it would be better to describe the build that's being tested....
> But does it ever make sense to build the python library statically? I legitimately don't know. If not, I won't apply this patch, and leave the exclusion be. I...
I would think it would make sense to just remove the `static` configuration from the matrix entirely. what configurations with a static build do you think are relevant or important?
oh, right. the main library needs to be buildable as static library. I think it's pretty safe to assume that a static library works if a shared library does though....
I tested this locally, it it works (as in, the tests are run): ``` $ cmake -Dbuild_tests=YES -GNinja . $ ninja $ ctest ```
I suspect `ctest` doesn't set up the library search paths correctly, to find the dependencies to the tests. maybe the tests can't be run when building shared.
if you rebase on top of `RC_1_2`, I think some more tests will pass. I don't know how to get `test_upnp` to work on appveyor, so I just disabled it...