Arvid Norberg
Arvid Norberg
I'm not convinced about `set_creator()` and `set_comment()` taking bytes. that seems wrong to me.
https://github.com/arvidn/libtorrent/pull/6149
https://github.com/arvidn/libtorrent/pull/6150
there is no `session_handle::find_torrent()` that takes an `info_hash_t`. Maybe there should be one, but I don't think it belongs on this list
This is an attempt to fix the DHT alert fields. It's not so easy to write a test for these, since you can't construct the alerts. Could you test it?...
I don't know what's going on with `dht_mutable_item_alert.item`
you don't think it would be reasonable to accept string as well, and encode it as UTF-8 into bytes?
how does this look? https://github.com/arvidn/libtorrent/pull/6125
@AllSeeingEyeTolledEweSew that patch, #6125, would you consider that to address this issue? Also, which one of your PRs do you think makes the most sense to land next?
I still don't understand the rationale for deprecating `str`. In a way it simplifies usage, since the caller doesn't need to know that strings are supposed to be UTF-8 encoded....