Arul Ajmani
Arul Ajmani
bors r=nvanbenschoten
I briefly looked at the `TestTenantSystemConfigUpgrade` failure and it makes sense -- it was exercising this code path, but we no longer need/have a cluster version check here: https://github.com/cockroachdb/cockroach/blob/677ef2c6b7f0accefce2b1b7de52902e0e0be984/pkg/config/system.go#L421-L424 We...
@celiala, like we talked about offline, I took this over sent out a PR https://github.com/cockroachdb/cockroach/pull/86676 with the failing test removed and some comment cleanup now that we don't have these...
@nvanbenschoten, I'm planning on tacking on a third commit that removes the use of `getNodeDescriptor` on here, but other than that this should be good for a look.
I'm removing the release blocker label here. We're running this test without retry loops. The test failed because a pusher noticed someone aborted its transaction -- I'll see if I...
Data-driven tests skewed post rebase. I'll try again. bors r=nvanbenschoten
I'm closing this for now. We realized late in the release cycle that there's a bit of complexity here during cluster bootstrapping -- the second (unpolished) commit is a stab...
Looks like CI is good now, I'll re-engage bors. Enjoy skiing @nvanbenschoten! bors r+
Adding the O-support label given this would have prevented https://github.com/cockroachlabs/support/issues/2841.