cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

concurrency: remove the concept of distinguished waiters

Open arulajmani opened this issue 1 year ago • 2 comments

Now that https://github.com/cockroachdb/cockroach/pull/119581 has landed, we no longer distinguish (no pun intended) between liveness pushes and deadlock detection pushes. This obviates the need for the concept of distinguished waiters. Removing them also serves as a nice cleanup, and gets us a step closer to things like generalized lock promotion.

Informs https://github.com/cockroachdb/cockroach/issues/110435

Release note: None

arulajmani avatar Feb 23 '24 17:02 arulajmani

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] avatar Feb 23 '24 17:02 blathers-crl[bot]

This change is Reviewable

cockroach-teamcity avatar Feb 23 '24 17:02 cockroach-teamcity

Build failed:

craig[bot] avatar Mar 05 '24 16:03 craig[bot]

Data-driven tests skewed post rebase. I'll try again.

bors r=nvanbenschoten

arulajmani avatar Mar 05 '24 16:03 arulajmani

Build succeeded:

craig[bot] avatar Mar 05 '24 18:03 craig[bot]