Arturo Bernal

Results 48 comments of Arturo Bernal

> @arturobernalg see this comment [#118 (comment)](https://github.com/esa/nanosat-mo-framework/pull/118#issuecomment-951703698) Hi @TanguySoto changed. TY

> I would not simplify pointless operations like 0_4, 1_4 - these are there to make the code more readable when defining a number of indexes/offsets, and the compiler optimises...

Hi @garydgregory you're right, I didn't realize that it actually requires version 1.7. How can i start the process to migrate the libs to java 1.8?

BTW sorry the size of the PR. But IMO it was necessary

HI @garydgregory > You really need to build the project locally before you create the PR, see the Javadoc errors. > > Aside from that, I'm starting to think that...

So do I have to change something? should I close the pr?

HI @mmariotti Thank you for your PR. Can you add test cases that cover all the possible path? TY

> Hi, > > interesting PR! :-) My only comment is that I'd extract the lock behaviour on a utility class something similar to (pseudocode, surely doesn't even compile): >...

> Hi @arturobernalg ! > > > However, this approach has limitations when it comes to working with condition variables and allowing for custom scenarios. Specifically, using a utility class...