nanosat-mo-framework icon indicating copy to clipboard operation
nanosat-mo-framework copied to clipboard

Published 20 hours ago • verified publisher icon esa

[refactor] Minors numeric improvements

Open arturobernalg opened this issue 3 years ago • 4 comments

  • Simplify pointless arithmetic expression.
  • Integer multiplication cast to long.
  • Use valueOf
  • Simplify pointless arithmetic expression.

arturobernalg avatar Oct 15 '21 15:10 arturobernalg

@arturobernalg see this comment https://github.com/esa/nanosat-mo-framework/pull/118#issuecomment-951703698

TanguySoto avatar Oct 26 '21 08:10 TanguySoto

@arturobernalg see this comment #118 (comment) Hi @TanguySoto changed. TY

arturobernalg avatar Nov 09 '21 17:11 arturobernalg

I would not simplify pointless operations like 04, 14 - these are there to make the code more readable when defining a number of indexes/offsets, and the compiler optimises it out anyway. As for other changes - they look good to me. Please rebase on top of the latest dev.

dmarszk avatar Jun 22 '22 15:06 dmarszk

I would not simplify pointless operations like 0_4, 1_4 - these are there to make the code more readable when defining a number of indexes/offsets, and the compiler optimises it out anyway. As for other changes - they look good to me. Please rebase on top of the latest dev.

Ok, I already rebase from master and revert the pointless simplifications.

arturobernalg avatar Jun 22 '22 19:06 arturobernalg