commons-lang icon indicating copy to clipboard operation
commons-lang copied to clipboard

add StringUtils.substringBeforeLast(String, int)

Open mmariotti opened this issue 2 years ago • 2 comments

Hello, This method with int param is missing :)

mmariotti avatar Oct 09 '22 09:10 mmariotti

Codecov Report

Merging #967 (731f99b) into master (ff733d9) will decrease coverage by 0.02%. The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #967      +/-   ##
============================================
- Coverage     91.99%   91.96%   -0.03%     
- Complexity     7432     7433       +1     
============================================
  Files           189      189              
  Lines         15664    15670       +6     
  Branches       2907     2908       +1     
============================================
+ Hits          14410    14411       +1     
- Misses          677      683       +6     
+ Partials        577      576       -1     
Impacted Files Coverage Δ
...ain/java/org/apache/commons/lang3/StringUtils.java 98.45% <0.00%> (-0.36%) :arrow_down:
...apache/commons/lang3/reflect/ConstructorUtils.java 86.00% <0.00%> (+2.00%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Oct 09 '22 10:10 codecov-commenter

HI @mmariotti Thank you for your PR. Can you add test cases that cover all the possible path?

TY

arturobernalg avatar Oct 13 '22 20:10 arturobernalg