Arthur Taylor

Results 58 comments of Arthur Taylor

So, this leaves a question of what to do about the situation. The current solution is broken. Any text passed to `sf_set_string()` will be interpreted as if it was latin-1...

> So currently libsndfile doesn't write ID3v2 tags even when there is non-ASCII data present because of this issue of interpreting everything as latin1? Is this latin1 issue coming from...

By spec, ID3v1 is limited to latin-1. So I think if there were to be a function which wrote UTF-8 tags, when writing the ID3v1 tag it should do a...

`SFC_GET_BITRATE_MODE` was added for MP3 support, and at this time only MP3 currently implements it. Of the supported formats, only Vorbis also could. I cannot think how it would be...

Hi @sammlapp . To expand on @evpobr 's comment, yes both bitrate mode and bit rate value are configurable using `sf_command()`. Sample rate mode can be changed using `SFC_SET_BITRATE_MODE` -...

> We have identified a Heap-buffer-overflow memory bug in sndfile.c in commit c81375f070f3c676496 *As* of commit c81375f070f3c676496. Identified commit id is not a bisection.

Good idea. I just want to do some more testing before giving the okay. What do you think @erikd, @evpobr, @SoapGentoo? As a tangent, what are people's thoughts about the...

Cool, hey thanks. I have limited experience with Gradle, very little with Android dev, so I don't think I can review this. @SoapGentoo @evpobr ? Would you, @jg-hot , feel...