Arthur Taylor
Arthur Taylor
Erik's style is an acquired taste, but I don't mind it now, and the pre-commit hooks he wrote do a good job of enforcing it. I'm just maybe a bit...
~~Actually, this is fixed in master from the MP3 changes:~~ ~~https://github.com/libsndfile/libsndfile/commit/444d9a4c8af0f2f4e0b35ed1cdf9203451853620~~ Edit: Oops, no, it's not. That commit fixes ID3v1 trailers screwing up the WAV chunk parser. The issue in...
Also, non-ascii isn't the issue. The `INAM` field of the `INFO` tag litterally is `??????` in the provided file: ``` 00023b50 69 02 42 13 d5 14 1b 10 1c...
Confirmed, investigating.
Dump off the sndfile log from opening the file ``` File : myfile.opus Length : 487995 Ogg stream data : Opus Stream serialno : 2088749492 Opus library version: libopus 1.3.1...
Okay, made progress. Ogg based formats have no seek-tables, and require file searching and page syncs to seek. The routine that does the seek position estimating and binary search of...
Tested with parasitic data (Ogg pages that continue, packets that span multiple pages), and yes the fix is correct. Fixes Vorbis seeking. Opus seeking still has an over count issue...
This issue, Opus seeking, has been fixed by PR #826. Vorbis seeking, while better still experiences some issues on near-seeks.
Closing as fixed. @krisfed please re-open if not :)
In general, sample-based lossy subformats in libsndfile are not seekable (ADPCM, G.721, GSM). The decoder state required to decode correctly at a particular sample position depends on some (or all)...