Arthur Taylor
Arthur Taylor
Correction, the chunk parser DOES heed the padding byte. So the only bug really is the log message, which is in fact spurious.
>> The bug is that we write such an odd-length file, that no padding byte is added to the end. > i think this is the real bug. Except it's...
And it writes the padding byte if there aren't any trailing chunks as well ```hexdump 00000000 52 49 46 46 8a 00 00 00 57 41 56 45 66 6d...
So I think the bug is just that the message complaining about odd length data chunks is wrong. The message makes no sense, it is triggered when the data chunk...
> otoh, i have no idea why the chose a term like WORD boundary It's MS. The terms "WORD" (and "DWORD", "QWORD") are dogma there. They made the choice to...
Thanks for the report. Closing as fixed.
The assert is in the external dependency `libmp3lame`. Digging into it, it seems there is a bug handling the normal / denormal source. The MP3 encoding code is treating the...
Humm. Initially I would side with `#include ` as it at the very least provides separation if any dependency does something dumb like have a header like `#include ` which...
Libsndfile supports both ID3 v1 and ID3 v2, using both libmp3lame and libmpg123 to do the actual work. https://github.com/libsndfile/libsndfile/blob/master/src/mpeg_decode.c#L462 When reading a file, v2 tags take precedence over v1 tags....
Turns out I was wrong on that point. I wrote the code, but it was a long time ago now :laughing: libsndfile does not work like `lame --add-id3v2`, and liblame...