Artem Dudarev
Artem Dudarev
Fixed in the following PRs: https://github.com/VirtoCommerce/vc-platform/pull/2486 https://github.com/VirtoCommerce/vc-platform/pull/2593
Why do you need an inherited image id?
These changes will break custom modules that override services with `IItemService` argument in the constructor. `ProductDocumentBuilder` for example. If custom module overrides the `IItemService` itself, it will also break, because...
### 1. Overriden services with `IItemService` argument in the constructor ```csharp public class MyProductDocumentBuilder : ProductDocumentBuilder { public MyProductDocumentBuilder(..., IItemService itemService, ...) : base(... itemService, ...) } ``` ```csharp serviceCollection.AddTransient();...
Did you try to run this code? It doesn't work for me: ``` System.InvalidOperationException: Unable to activate type 'VirtoCommerce.CatalogModule.Data.Search.ProductSearchService'. The following constructors are ambiguous: Void .ctor(System.Func`1[VirtoCommerce.CatalogModule.Data.Repositories.ICatalogRepository], VirtoCommerce.Platform.Core.Caching.IPlatformMemoryCache, VirtoCommerce.CatalogModule.Core.Services.IProductService, Microsoft.Extensions.Options.IOptions`1[VirtoCommerce.Platform.Core.GenericCrud.CrudOptions]) Void...
A new image does not overwrite the old one.