vc-module-catalog icon indicating copy to clipboard operation
vc-module-catalog copied to clipboard

Published 20 hours ago • verified publisher icon VirtoCommerce

variation image inherits id from parent product image

Open henrykavalev opened this issue 1 year ago • 5 comments

Description

If requesting a variation product with images that are saved within the parent product, then the id is manually set to null. This PR is setting id to the parent product image id. That way it will return the same image id as if one would request the parent product image id.

References

QA-test:

Jira-link:

Artifact URL:

henrykavalev avatar Oct 04 '23 10:10 henrykavalev

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 04 '23 10:10 CLAassistant

Reveiw task created: https://virtocommerce.atlassian.net/browse/PT-13854

vc-ci avatar Oct 04 '23 10:10 vc-ci

Why do you need an inherited image id?

artem-dudarev avatar Oct 25 '23 14:10 artem-dudarev

Since the other parameters were inherited from parentAssetBase, it led on our side to the question why it is not done for the id as well. For us it is easier to differentiate between pictures based on the id instead of the name. For example working on frontend with Keys of the HTML Lists Items, where we could use Id as the Key to avoid duplicated image names.

henrykavalev avatar Oct 25 '23 14:10 henrykavalev

Hello together, since there are no updates on this issue for some time now, I wanted to ask whether this issue will be implemented or if I can help in any other way regarding this suggestion?

henrykavalev avatar Nov 28 '23 10:11 henrykavalev