arshadd-b

> @arshadd-b I feel this PR needs refactoring overall in terms of limiting the tests specific to individual func and its scope. Refactored the PR, tests are now scoped to...

> Please add a test case for `createVPCSecurityGroup` & `createVPCSecurityGroupRulesAndSetStatus` too even if it's a minor one. Have added test cases for `createVPCSecurityGroup` & `createVPCSecurityGroupRulesAndSetStatus`

Hi @sbueringer I have tried to cover the entire function reconcileDelete but these are pending blocks and all are negative test cases - https://github.com/kubernetes-sigs/cluster-api/blob/main/internal/controllers/machine/machine_controller.go#L459 - https://github.com/kubernetes-sigs/cluster-api/blob/main/internal/controllers/machine/machine_controller.go#L488 - https://github.com/kubernetes-sigs/cluster-api/blob/main/internal/controllers/machine/machine_controller.go#L508 could you...

/retest

Hi @enxebre @alexander-demicev I have addressed all the review comments, could you please a look Thanks

/retest

/assign

Hi @chrischdi , I had gone the E2E Framework code What I can understand is, we are printing the logs on console and picking from console (stderr or stdout )...

Hi @chrischdi >in this case we already dump the pod.yaml in this case we already grab /var/log/pods from the node's of the management cluster I will verify these two things...

Hi @chrischdi I can see we are collecting logs for `/var/log/pods` [here](https://github.com/kubernetes-sigs/cluster-api/blob/3656b4949546ed67d87ac3b1180a99c29ec0c16b/test/framework/docker_logcollector.go#L186) for this case `in this case we already dump the pod.yaml` I can see inside this function `DumpAllResourcesAndLogs`...