Add UT for ReconcileVPCSecurityGroups function

[arshadd-b]

What this PR does / why we need it: Add UTs for ReconcileVPCSecurityGroups function and fixes minor bug found during writing UTs Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

/area provider/ibmcloud

1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Add UT for ReconcileVPCSecurityGroups function

[linux-foundation-easycla[bot]]

The committers listed above are authorized under a signed CLA.

• :white_check_mark: login: arshadd-b (4764898db7a08406c2bd41fdd4a6ec6fdc88e3a4)

[k8s-ci-robot]

Welcome @arshadd-b!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-ibmcloud 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-ibmcloud has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

[k8s-ci-robot]

Hi @arshadd-b. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify[bot]]

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name	Link
🔨 Latest commit	4764898db7a08406c2bd41fdd4a6ec6fdc88e3a4
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/67348c935bb6ec00084eb611
😎 Deploy Preview	https://deploy-preview-2011--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[Amulyam24]

/easycla

[Amulyam24]

/ok-to-test

[Prajyot-Parab]

@arshadd-b Please update What this PR does / why we need it: & Release note:

[Karthik-K-N]

/cc @dharaneeshvrd

[arshadd-b]

@arshadd-b I feel this PR needs refactoring overall in terms of limiting the tests specific to individual func and its scope. Refactored the PR, tests are now scoped to specific function.

[arshadd-b]

Please add a test case for createVPCSecurityGroup & createVPCSecurityGroupRulesAndSetStatus too even if it's a minor one.

Have added test cases for createVPCSecurityGroup & createVPCSecurityGroupRulesAndSetStatus

[Karthik-K-N]

@arshadd-b could you please rebase the PR.

[Karthik-K-N]

Thanks @arshadd-b and @dharaneeshvrd

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arshadd-b, dharaneeshvrd, Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [Prajyot-Parab]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment