Andrew Rosiclair
Andrew Rosiclair
Yeah I'm not sure what could be causing this either. FWIW I can't repro this on Android v1.2.5-2
@nkdengineer's proposal LGTM > Instead of having a separate ButtonWithDropdown component, we can add a prop to ButtonWithDropdownMenu to control this button style. Yeah I think we should do this...
Oh I see @luacmartins self assigned. Lemme know if you still want to manage otherwise I can handle it 👍
Tested the airship fix on staging v1.2.99-4. It did fix the notification click handler, however we're still not always navigating to the correct report (tested on Android). It seems we...
@marcaaron do you have the bandwidth to prioritize this? It's being considered a [critical bug](https://expensify.slack.com/archives/C04E99DVBTP/p1681311250751799?thread_ts=1680980284.168379&cid=C04E99DVBTP). If not I can take over.
This [view](https://giphy.com/gifs/QUKywDRN3qUwBFaziO). Swipe up from the bottom and hold for a second. Then you can swipe the app away to kill it. Also just added another step for opening a...
@tienifr's proposal looks good let's just modify the logs slightly: ```javascript Log.info(`[SequentialQueue] '${commandName}' command queued. Queue length is ${PersistedRequests.getLength()}`); ``` ```javascript if (PersistedRequests.getLength() > 0) { Log.info(`[API] '${commandName}' is waiting...
`bundle install` step fails for me so I'm blocked on reviewing this. [Posted about it on slack](https://expensify.slack.com/archives/C03TQ48KC/p1668443005443399).
## Reviewer Checklist - [x] I have verified the author checklist is complete (all boxes are checked off). - [x] I verified the correct issue is linked in the `###...
Sounds like this is ready for the review checklist?