Members list blinking when user goes from offline to online - reported by @gadhiyamanan

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. turn off Internet Connection
2. Go to settings > Workspace >Manage Members
3. turn on Internet Connection
4. check members list

Expected Result:

Members list should not blink

Actual Result:

Members list should blinking

Workaround:

unknown

Platform:

Where is this issue occurring?

• iOS
• Android

Version Number: 1.1.99-0 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/43995119/190949938-62dc9b37-da1c-450e-90be-a73988b05f41.mp4

Expensify/Expensify Issue URL: Issue reported by: @gadhiyamanan Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1661604591133289

View all open jobs on GitHub

[melvin-bot[bot]]

Triggered auto assignment to @Christinadobrzyn (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[Christinadobrzyn]

oh interesting, I'm not sure if this will be part of the bigger offline project. I can't find any other GHs related to this but going to get a second opinion from eng about this fix happening now or later.

[melvin-bot[bot]]

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[stitesExpensify]

cc @vitHoracek do you know if this is already being worked on in the policy refactor?

[mountiny]

@stitesExpensify I havent worked on this one specifically so I am not sure. I think it was @neil-marcellini who worked on policy related refactorings.

However, I have seen this blinking on unstable wifi in multiple components, so this actually might be related to the offline indicator.

[neil-marcellini]

Here is the Workspace refactor tracking issue. The only thing that has been changed about the workspace members so far is this issue for GetFullPolicy.

[stitesExpensify]

So it looks like we will be doing some work on the members list page then, should we just put this on hold until those are done?

[melvin-bot[bot]]

@stitesExpensify Huh... This is 4 days overdue. Who can take care of this?

[stitesExpensify]

bump @neil-marcellini any thoughts on :that: ?

[neil-marcellini]

Hmm I'm really not sure. I don't think we should hold on this, it seems unrelated to any refactors we are doing. cc @arosiclair and @chiragsalian.

[arosiclair]

Yeah I'm not sure what could be causing this either. FWIW I can't repro this on Android v1.2.5-2

[stitesExpensify]

hmm do you know if this is still happening @mvtglobally ?

[melvin-bot[bot]]

@stitesExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[stitesExpensify]

Waiting to see if this is still reproducible

[stitesExpensify]

Still waiting for confirmation that this is broken

[melvin-bot[bot]]

@stitesExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mountiny]

I think it does not need to be daily now as we wait to see what are the reproduction steps

[stitesExpensify]

@mvtglobally is this still on the list of issues we're testing?

[stitesExpensify]

bump @mvtglobally

[mvtglobally]

@stitesExpensify Team checked on recent build and issue is not repro https://user-images.githubusercontent.com/43995119/199122285-b888b733-40df-4986-ab3a-b77967363a88.MOV https://user-images.githubusercontent.com/43995119/199122306-66d77a80-bc5b-408f-b4b5-dc1fbabd1f83.MOV

[stitesExpensify]

Great, thanks!