Andrew McKnight

Results 173 comments of Andrew McKnight

Just to update on what is happening in this code: we get thread information from `thread_get_state(...)` in mach/thread_act.h, which includes pointers to memory locations that contain the backtrace frame information...

We merged https://github.com/getsentry/sentry-cocoa/pull/4268 some time ago to attempt to fix this issue, released in 8.34.0, so I will close this issue. If there are still problems related to this occurring,...

Actually, this looks like a duplicate of #3223. Let's keep discussion over there, since it looks like the fix did not eliminate the crash.

Hi @coolguyzone , sorry I missed your message. Yes, I'm preparing to merge this PR now.

@bruno-garcia I think the two index.mdx could actually be combined here. Also, I removed the docs for crash dialogs, as I haven't implemented anything like that.

@bruno-garcia Finally got it working again, here are the relevant pages: - top level overview: https://sentry-docs-git-armcknight-featuser-feedbackcocoa-docs.sentry.dev/platforms/apple/user-feedback/ - configuration: https://sentry-docs-git-armcknight-featuser-feedbackcocoa-docs.sentry.dev/platforms/apple/user-feedback/configuration/

Thanks @chargome! FYI to all, I'm waiting to merge this PR until https://github.com/getsentry/sentry-cocoa/pull/4873 is approved, so we have alignment between the docs and implementation.

OK Actually, that last PR is merged, but i'm going to wait until we merge _and deploy_ https://github.com/getsentry/sentry-cocoa/pull/4874

That last release was retracted, now waiting on deployment of https://github.com/getsentry/publish/issues/5144

I think i needed some of the test fixes that would come it with https://github.com/BinaryBirds/git-kit/pull/13, so i rebased on top of that, but GitHub doesn't have good stack branch UX...