Andrew McKnight

Results 173 comments of Andrew McKnight

@brustolin accessibility sizes and right-to-left languages are known tasks: https://github.com/getsentry/sentry-cocoa/issues/4270#issuecomment-2408210459 I already have right-to-left support going after i linked the PR last night, see the latest update in the issue:...

> I think configureTheme, should be inside configureWidget, or at least the properties that configure the widget, it took me an extra second to find this out, when it would...

> [This](https://github.com/getsentry/sentry-cocoa/pull/4364#issuecomment-2370418184) need to be addressed before merging the PR. @brustolin Would you mind if we do it in a separate PR along with https://github.com/getsentry/sentry-cocoa/pull/4364#discussion_r1787018390? I just don't want to...

> > @brustolin Would you mind if we do it in a separate PR along with [#4364 (comment)](https://github.com/getsentry/sentry-cocoa/pull/4364#discussion_r1787018390)? I just don't want to mess the diff up here. Nothing is...

I just noticed this because I went to write another test case for a new function in SentryError. The test run crashed while this test case was running, but I...

I think this got automatically closed due to the way it was included in the PR description.

Same failure mode as in https://github.com/getsentry/sentry-cocoa/issues/2300. The `SentryDebugImageProvider` returns no image. It could potentially happen if there is no sample data, but this has never happened since these tests were...

We could try extending the delay from e.g. 2 to 3 seconds, or increasing the upper limit in that for loop, or just remove the assertions around the debug images...

Also seeing it happen in `testProfilingDataContainsEnvironmentSetFromOptions`, really all the profiling tests there are written the same way so will have the same potential defect.

That should only cause problems during a crash though; since this is during normal process execution I wouldn't expect that to break.