sentry-docs icon indicating copy to clipboard operation
sentry-docs copied to clipboard

Cocoa User Feedback

Open armcknight opened this issue 1 year ago • 4 comments

DESCRIBE YOUR PR

Documents a new feature for gathering User Feedback in a Cocoa app, based on the similar feature we already ship in e.g. sentry-javascript. Used https://docs.sentry.io/platforms/javascript/user-feedback/ as inspiration.

sentry-cocoa PR that declares the API: https://github.com/getsentry/sentry-cocoa/pull/4284; tracking work at https://github.com/getsentry/sentry-cocoa/issues/4269

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • [ ] Urgent deadline (GA date, etc.):
  • [ ] Other deadline:
  • [x] None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • [ ] Checked Vercel preview for correctness, including links
  • [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • [ ] PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

armcknight avatar Aug 29 '24 19:08 armcknight

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2025 0:27am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 0:27am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 0:27am

vercel[bot] avatar Aug 29 '24 19:08 vercel[bot]

Bundle Report

Changes will increase total bundle size by 225 bytes (0.0%) :arrow_up:. This is within the configured threshold :white_check_mark:

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.94MB 231 bytes (0.0%) :arrow_up:
sentry-docs-client-array-push 9.39MB -6 bytes (-0.0%) :arrow_down:

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.71MB -0.0%
../instrumentation.js -3 bytes 1.04MB -0.0%
9523.js -3 bytes 1.02MB -0.0%
../app/[[...path]]/page.js.nft.json 80 bytes 379.07kB 0.02%
../app/platform-redirect/page.js.nft.json 80 bytes 378.98kB 0.02%
../app/sitemap.xml/route.js.nft.json 80 bytes 376.95kB 0.02%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 865.35kB -0.0%
static/chunks/1298-*.js -3 bytes 401.61kB -0.0%
static/jPz5REmRuDGPAYe8NTJay/_buildManifest.js (New) 578 bytes 578 bytes 100.0% :rocket:
static/jPz5REmRuDGPAYe8NTJay/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% :rocket:
~~static/1YkbTd4zmBuamvDAhdUlQ/_buildManifest.js~~ (Deleted) -578 bytes 0 bytes -100.0% :wastebasket:
~~static/1YkbTd4zmBuamvDAhdUlQ/_ssgManifest.js~~ (Deleted) -77 bytes 0 bytes -100.0% :wastebasket:

codecov[bot] avatar Aug 29 '24 19:08 codecov[bot]

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

getsantry[bot] avatar Sep 25 '24 07:09 getsantry[bot]

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

getsantry[bot] avatar Oct 18 '24 07:10 getsantry[bot]

Hey @armcknight , just checking in, are we waiting on something to merge these changes?

coolguyzone avatar Oct 31 '24 21:10 coolguyzone

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

getsantry[bot] avatar Nov 22 '24 08:11 getsantry[bot]

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

getsantry[bot] avatar Dec 15 '24 08:12 getsantry[bot]

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

getsantry[bot] avatar Jan 07 '25 08:01 getsantry[bot]

Hi @coolguyzone , sorry I missed your message. Yes, I'm preparing to merge this PR now.

armcknight avatar Jan 11 '25 00:01 armcknight

@bruno-garcia I think the two index.mdx could actually be combined here. Also, I removed the docs for crash dialogs, as I haven't implemented anything like that.

armcknight avatar Jan 11 '25 02:01 armcknight

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

getsantry[bot] avatar Feb 01 '25 08:02 getsantry[bot]

@armcknight closed/reopen to see if Vercel runs another build. The current one seems expired

bruno-garcia avatar Feb 18 '25 23:02 bruno-garcia

@bruno-garcia Finally got it working again, here are the relevant pages:

  • top level overview: https://sentry-docs-git-armcknight-featuser-feedbackcocoa-docs.sentry.dev/platforms/apple/user-feedback/
  • configuration: https://sentry-docs-git-armcknight-featuser-feedbackcocoa-docs.sentry.dev/platforms/apple/user-feedback/configuration/

armcknight avatar Feb 19 '25 23:02 armcknight

Pushed a small change to your table so it stops overflowing!

chargome avatar Feb 20 '25 10:02 chargome

Thanks @chargome!

FYI to all, I'm waiting to merge this PR until https://github.com/getsentry/sentry-cocoa/pull/4873 is approved, so we have alignment between the docs and implementation.

armcknight avatar Feb 20 '25 19:02 armcknight

OK Actually, that last PR is merged, but i'm going to wait until we merge and deploy https://github.com/getsentry/sentry-cocoa/pull/4874

armcknight avatar Feb 24 '25 23:02 armcknight

That last release was retracted, now waiting on deployment of https://github.com/getsentry/publish/issues/5144

armcknight avatar Mar 01 '25 05:03 armcknight