sentry-cocoa icon indicating copy to clipboard operation
sentry-cocoa copied to clipboard

Fix flaky `testSerializeWithUnderlyingNSException`

Open philipphofmann opened this issue 3 years ago • 4 comments

GitHub action Run Link

https://github.com/getsentry/sentry-cocoa/actions/runs/3465967126/jobs/5789326262

Disabling PR

https://github.com/getsentry/sentry-cocoa/pull/2387

Description

Also failing https://github.com/getsentry/sentry-cocoa/actions/runs/3468074702/jobs/5793551381

philipphofmann avatar Nov 15 '22 07:11 philipphofmann

@armcknight, could you please look at this test as you wrote it?

philipphofmann avatar Nov 15 '22 07:11 philipphofmann

I just noticed this because I went to write another test case for a new function in SentryError. The test run crashed while this test case was running, but I really don't see how this test case could crash. Running it locally doesn't crash, I'm guessing this is the same statefulness issue that has been plaguing the test suite. I'm going to reenable it and let's see what happens.

armcknight avatar Jan 12 '23 18:01 armcknight

I think this got automatically closed due to the way it was included in the PR description.

armcknight avatar Jan 12 '23 18:01 armcknight

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

github-actions[bot] avatar Feb 03 '23 00:02 github-actions[bot]

The test testSerializeWithUnderlyingNSException is enabled. This issue is out of date. We can close it.

philipphofmann avatar Nov 17 '25 15:11 philipphofmann