armandomontanez

Results 47 comments of armandomontanez

cc_tool builds src for wrong platform

Thanks for the excellent writeup @katre, I'm going to bookmark this! 😁 I spent some time playing @fmeum's example and I think I better understand the nuances of this problem....

Document preferred way to add opt only compile flags with rules based toolchain

Sorry this got lost in time, @cerisier's suggestion is the intended approach. We should definitely document this, though!

Make strip_include_prefix apply to textual_hdrs

Still seeing failures internally, we might need to put this behind a flag if we don't want to block on Whatever Problems Google Has.

Remove allowlist_include_directories from data

Yeah, the tests ensure `cxx_builtin_include_directories` add files to toolchain file groups since it was part of the API contract.

Remove allowlist_include_directories from data

On that note, probably deserves a documentation update to clarify any changes in behavior.

Rule based toolchains should expand `args` with `data`

The `cc_args.format` attribute can do this today, and can handle expansion of `directory` rules from `bazel_skylib` as well as files and `cc_variable`s. I don't think there's a significant reason to...

Fix layering_check with path stripping and textual_hdrs

Need to run through a few rounds of presubmit testing to make sure the previous failures don't show up again. thanks for the ping.