rules_cc icon indicating copy to clipboard operation
rules_cc copied to clipboard

Fix layering_check with path stripping and textual_hdrs

Open keith opened this issue 1 month ago • 6 comments

Previously textual_hdrs paths were eagerly fetched which breaks path stripping. This wires these headers up separately to treat them like hdrs.

Fixes https://github.com/bazelbuild/bazel/issues/27718

keith avatar Nov 19 '25 01:11 keith

i chose to split these out from additional_exported_headers because that field is undocumented and publicly unused. If googlers validate it wouldn't break them we could instead change the type of that argument to be a list of Files instead of a list of strings.

keith avatar Nov 19 '25 01:11 keith

ptal @fmeum @pzembrod

keith avatar Nov 19 '25 01:11 keith

@c-mita @trybka @pzembrod friendly ping

keith avatar Dec 03 '25 00:12 keith

@c-mita @trybka @pzembrod friendly ping

keith avatar Dec 18 '25 17:12 keith

Need to run through a few rounds of presubmit testing to make sure the previous failures don't show up again. thanks for the ping.

armandomontanez avatar Dec 18 '25 18:12 armandomontanez

thanks!

keith avatar Dec 18 '25 18:12 keith