Prophet holidays

[tserekh]

Adding Indonesia, Thailand, Philippines and Pakistan Belarus is already in library. Based on holidays from Prophet but have many changes because Prophet include not only public holidays.

https://github.com/dr-prodigy/python-holidays/issues/538

[tserekh]

I am confused about computed test coverege. How it should be improved?

[coveralls]

Pull Request Test Coverage Report for Build 1538644284

• 335 of 410 (81.71%) changed or added relevant lines in 5 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-1.5%) to 96.339%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
holidays/countries/indonesia.py	95	119	79.83%
holidays/countries/thailand.py	98	149	65.77%
<!--	Total:	335	410

Totals
Change from base Build 1537386807:	-1.5%
Covered Lines:	6035
Relevant Lines:	6178

---

💛 - Coveralls

[dr-prodigy]

Hi @tserekh thanks for this great work! You can find details on how to do test and improve coverage here: https://github.com/dr-prodigy/python-holidays/tree/beta#running-tests-and-coverage

In particular, the second command should help you find out which code is not yet covered.

Cheers!

[tserekh]

@dr-prodigy, thank you. I am going to imrpove test coverage

[tserekh]

If think test coverege is so low due to hardcoded holidays. It is hardcoded due to dependency of lunar calendar on geographic coordinates. Now I am working on implemention universal lunar calender for any coordinates using https://github.com/brandon-rhodes/pyephem

[dr-prodigy]

hi @tserekh could you proceed in your above activity? thx, best 👍

[arkid15r]

Continued in https://github.com/dr-prodigy/python-holidays/pull/887