Arik comments

Results 56 comments of


                                            Arik

documentation: Describe the state machine

Where do you think this description is most aptly placed?

Construct Trampoline onion from path.

Thanks for the feedback, @TheBlueMatt! I'll update #2756 to reflect your recommendations.

Construct Trampoline onion from path.

Yeah, ish, but absent a Receive variant, it's gonna completely break, so I think once 2906 is in I'll need to rework this. Bastien has been very helpful with trampoline...

Better document distinction between channel/chain monitor

I think the confusion stems from the objects sounding so similar, even though they clearly refer to very different components. This is a hard one, but imo, definitely a big...

Batch on-chain claims more aggressively per channel

This seriously helped with previously broken unit tests for a PR I'm working on, thank you so much!

Send latest revocation_secret for channels force-closed by counterparty upon closure confirmation

Yup, very much so. It's a medium-term future issue, I think. I imagine the spec should be fairly straightforward (famous last words).

Send latest revocation_secret for channels force-closed by counterparty upon closure confirmation

thanks for adding the label!

Trampoline onion format (Feature 56/57)

Awesome, thank you so much! Will update corresponding test vectors ASAP!

Trampoline onion format (Feature 56/57)

Incredible, thanks so much!

Convert `check_htlc_valid_counterparty` and `log_claim` macros to fns

Looks good to me, though obviously pending #3057 getting merged and its macro refactoring commits getting dropped.