Ariel Valentin
Ariel Valentin
@kaylareopelle Is this of interest to you?
@nvolker would you mind taking a look at this again? It seems the test suite is non-deterministic and fails occasionally: e.g. https://github.com/open-telemetry/opentelemetry-ruby-contrib/actions/runs/3790399834/jobs/6444991776#step:4:357
@scbjans My apologies. I missed the request and allowed this PR to become stale. I have merged main and am waiting on a rebuild.
@nvolker Looks like we have linter errors on this now with latest Rubocop https://github.com/open-telemetry/opentelemetry-ruby-contrib/actions/runs/4346678153/jobs/7593036414
Adding some additional work to this PR. This instrumentation now defaults to using `Rack::Events` as opposed to the classic middleware and will also need to be updated to support this...
@qnm Thank you for being willing to help! We have very limited capacity and are in need of additional maintainers to help with instrumentation. Please open a PR at your...
@supaspoida following up. I am going to assume that this is working for newer versions of the gem. Please reopen if you still need help.
cc: https://github.com/open-telemetry/opentelemetry-ruby/pull/1237
You should be able to override the error handler without monkey patching: https://github.com/open-telemetry/opentelemetry-ruby/blob/c7ef4085cb020d62725da1f3dc29f169dd1db267/api/lib/opentelemetry.rb#L27 You can see an examples of how we do it as part of initialization for our test...
Thanks for your feedback! One of the challenges we face is not having any dedicated maintainers of the gRPC exporter, which is largely the reason we haven't published it. We...