Ariel Valentin

Results 113 comments of Ariel Valentin

@ahayworth I mentioned this in slack already but I was wondering if we could chat to discuss some possible changes to the layout of the source. One thing we have...

The generator groups by prefix, so it only generates one additional level because in many instances a group has fewer than 10 attributes. We also shorted the length of the...

> Specifically, we could validate what people are providing there and either warn or reject values that do not comply with a given spec version. That could be nifty. That...

> (And in any case, it's not blocking this PR :D ) I appreciate that though after you pointed out that this is not generating the instrumentation semconv directory I...

> I am against it for the following reasons: > > This behavior is not part of the current specification. The specification states that batch receive should store links to...

@robertlaurin Following up on our conversation from last week re: https://github.com/open-telemetry/opentelemetry-ruby/pull/1025. Please correct me if I am misrepresenting your concerns and suggestions. Some of concerns you brought up were: 1....

@robbkidd Here is a list of items we brainstormed as part of the more comprehensive guide: - events - set_attributes vs add_attributes - semantic conventions - `in_span` helper vs API/SDK...

ping @open-telemetry/ruby-maintainers @open-telemetry/ruby-approvers

@fbogsany please review again at your leisure.

ping @open-telemetry/ruby-maintainers