opentelemetry-ruby-contrib icon indicating copy to clipboard operation
opentelemetry-ruby-contrib copied to clipboard

Allow Rack :untraced_endpoints to include Regexp

Open johnnyshields opened this issue 3 years ago • 1 comments

johnnyshields avatar Jul 23 '22 17:07 johnnyshields

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: johnnyshields / name: Johnny Shields (8935cb9c9b71bb9dfecd3e80632f83173743b5b1, 38df2cf00cd1819a0e6f53a9ba276e6b3ae31ea1, 78cf8f7e767427f6cf0062fc346f9c1d035dde18, 7c8b59d410b53c2c90f22b8403b1f6760144b341, 50096a3a6a7517d12991913c2330e45cbaa146e2)
  • :white_check_mark: login: kaylareopelle / name: Kayla Reopelle (she/her) (105cc0e93c47a92bdea9ffaf0fb0ce25baee23f4)

👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot

github-actions[bot] avatar Apr 27 '23 01:04 github-actions[bot]

Hi @johnnyshields! Thanks for re-requesting a review on this PR. We're slowly trying to catch up on PRs that've been open for a long time.

@ahayworth, @fbogsany, @robertlaurin - Have your concerns been resolved?

kaylareopelle avatar Jan 17 '24 19:01 kaylareopelle

cc @open-telemetry/ruby-contrib-approvers and @open-telemetry/ruby-contrib-maintainers - please take a look if you're able!

kaylareopelle avatar Jan 17 '24 19:01 kaylareopelle

Adding some additional work to this PR.

This instrumentation now defaults to using Rack::Events as opposed to the classic middleware and will also need to be updated to support this option.

https://github.com/open-telemetry/opentelemetry-ruby-contrib/tree/main/instrumentation/rack#rack-middleware-vs-rack-events

arielvalentin avatar Jan 18 '24 05:01 arielvalentin

👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot

github-actions[bot] avatar Feb 23 '24 01:02 github-actions[bot]