AngelBottomless

Results 137 comments of AngelBottomless

Someone suggested me that if we can have separate file for optimizer, which can be distributed separately. I think its a good idea, so I'll try working on it.

![image](https://user-images.githubusercontent.com/35677394/199653451-31ded7a1-6f3b-435a-a916-6556f51f8ef5.png) Finished implementing and testing. ![image](https://user-images.githubusercontent.com/35677394/199653508-ec634050-6780-48e2-a042-06a8a3a3df48.png) Files will be saved separately as *.pt and *.pt.optim file. To use valid optimizer, it will now use hash value itself. Closes https://github.com/AUTOMATIC1111/stable-diffusion-webui/pull/4048

Temporarily closed for resolving conflict

Finished testing again: HNs file itself won't contain optimizer in any case. 1. Tested if HN can be saved and loaded with separate optimizer file. 2. Tested - HNs itself...

Yeah I removed that option (merging optimizer in checkpoint itself). Now its only saving it into separate `*.optim` file. I'll change explanation in shared.py

~~This makes () included in templates, should be fixed~~ fixed

by not applying protocol, so its just hitPos. I'll try some additional checks for paper, it would be just one option. It will be great if there's some way to...

``` if (!Objects.equals(mc.player.getServerBrand(), "fabric")){ } else if (Configs.Generic.EASY_PLACE_PROTOCOL_V3.getBooleanValue()) { //System.out.println("applied v3"); hitPos = applyPlacementProtocolV3(pos, stateSchematic, hitPos); } else { //System.out.println("applied v2"); hitPos = applyCarpetProtocolHitVec(pos, stateSchematic, hitPos); } ``` can do...

its on utils/WorldUtils.java

https://github.com/maruohon/litematica/blob/temp_1.17_update/src/main/java/fi/dy/masa/litematica/util/WorldUtils.java#L496 you're looking at wrong branch