Austin Gerlt
Austin Gerlt
This makes sense to me. As an additional point, most (maybe all?) other `from_*` functions in orix are for convention conversions. Moving this functionality would make the naming more consistent.
Not directly relevant, but looking through #594 , the logic in `Phase.point_group` seems like it should maybe also be moved, perhaps into `orix.quaternion.symmetry.get_point_group`...
`Arrow3D`got moved to it's own file during a module shuffle. I can fix it Sunday night if no one gets to it before me.
@ericpre , I think you are right, there are two unrelated but parallel issues. At minimum, i can definitely confirm the phrase `orix.plot._util import format_labels` only exists in orix 0.13.3,...
@ericpre, I was looking at the failing hyperspy tests, and noticed this: I think hyperspy is grabbing a now-defunct PR of kikuchipy to run tests against, hence the failing tests,...
@ericpre , Looks like you are correct. The line `Run #https://github.com/pyxem/kikuchipy/issues/707` still makes no sense to me, but I tried verbatim downloading the link you gave, and it does NOT...
I'm brand new to this concept, so I've got a base level question: what is the advantage to doing this over, say ,`[x.some_function(y) for x,y in zip(vector1,vector2)]`? Or, if you...
@CSSFrancis , is this still an issue?
Also, in case you haven't seen it in a bit, here is the orix PDF: https://orix.readthedocs.io/_/downloads/en/latest/pdf/ It looks good, I think it's just unnecessary.
Also, if someone on the MTEX team disagrees with my hotfix here, let me know and I can change it or delete it entirely.