Austin Gerlt
Austin Gerlt
Still needs some little fixes, as well as additional tests to cover the things those fixes fixed. Namely, in answering an email from @maclariz , I realized the axes are...
@ericpre : > As an alternative to editing file which can introduce issues, is it possible to acquire the smallest file possible by choosing appropriate scanning, reducing number of pixel,...
> It would be useful to document what hardware and software version are supported. Like list the supported versions in the file_reader docstring? Or is there a better way?
@ericpre , this feature isn't done, but I think I've addressed all your concerns. That said, between the black-vs-ruff, the repeated re-doing of the .app5 binaries, and a silly merge...
> Do anyone set any of these attributes after creation? If so, I'd say this is an antipattern, they should instead create a new phase. I agree.
I think as long as PG and SG are immutable, I could go either way on the lattice. If you make the lattice immutable, coding up the checks becomes way...
I've look at this a few times and had mixed thoughts, but I think I'm on board now. I tried rewriting a few examples in this suggested style, most felt...
I'm not as familiar as you two with the nuances of how RTD builds, but I'm fully on board with the main suggestion of doing away with notebooks for all...
> the IPF density plot example is slow because of the pole density calculation. It doesn't actually download the data. Agreed, yes. Sorry, I came to the same conclusion on...
> 2D titanium map is too heavy ... Just a thought, variations of this issue are going to start cropping up if we continue fleshing out EBSD features like `CrystalMap.Regions`...