Arda TANRIKULU comments

Results 597 comments of


                                            Arda TANRIKULU

AdditionalTypeDefs extensions between subgraphs do not apply when building subgraphs individually

`additionalTypeDefs` does not extend subgraphs, it extends the final supergraph.

fix: link merging

Thanks for the PR! Sorry for the late review!

Add warning before loadFileSync returns empty array

`loadFiles` loads available files for the given glob input. It is user's responsibility to check if the loaded files are correct or available. As you shared in the code. You...

`removeDescriptions` optimizer fails to remove descriptions from some nodes

I don't think descriptions are only supported on type definitions. You can try it by running the following code; ```ts import { parse } from 'graphql'; const document = parse(/*...

mergeTypeDefs produces incorrect output schema

Interesting use case. Not sure how intelligent we can make `mergeTypeDefs` to handle undefined `@link` directive. `mergeTypeDefs` today tries to merge directive definitions if they are not defined as repeatable....

fix `Warning: ReactDOM.render is no longer supported in React 18` for `@graphql-yoga/graphiql`

Fixed in https://github.com/dotansimha/graphql-yoga/pull/3526

SyntaxError: Named export 'OperationTypeNode' not found. The requested module 'graphql' is a CommonJS module, which may not support all module.exports as named exports.

We removed that dependency already in https://github.com/ardatan/graphql-tools/pull/7298 You mean updating it doesn't fix your issue?

SyntaxError: Named export 'OperationTypeNode' not found. The requested module 'graphql' is a CommonJS module, which may not support all module.exports as named exports.

@jdolle Could you take a look?

Remove short circuit preventing 'Failed to find any GraphQL type definitions' error from appearing

Not sure I understand the motivation behind this change. If it is an issue on codegen, then it needs to be fixed there not here.