Arda TANRIKULU comments

Results 597 comments of


                                            Arda TANRIKULU

Codegen with printSchema fails for ForbiddenError

You don't need to print the schema or pass the schema itself directly. You can just give the path to the schema. I guess "./schema" in your case

upgrade executor to non-duplicating incremental delivery format

I left a few comments. And some of them would probably fix the type checking issues.

Issue when migrating from @graphql-codegen/cli v1 to v5

You are migrating to a new major version so according to [SemVer](https://semver.org) it is expected to have breaking changes during this process. In other words, you cannot expect the same...

Feature Request: change "singingKeyProviders" in JwtPluginOptions to "signingKeyProviders"

Fixed in the latest version!

docs: add integration guide for GraphQL Yoga with Nuxt 4

Thanks for the docs! Do you think we can create integration tests with an example in the repo like we do for other integrations?

docs: add integration guide for GraphQL Yoga with Nuxt 4

Here we have examples for different integrations, Next.js, Fastify etc, and each of them have integration tests in the same folder. https://github.com/dotansimha/graphql-yoga/tree/main/examples

Error Masking incorrectly sets `extensions.originalError` vs `error.originalError`

`error.extensions.originalError` is intentional in order to allow users to see the original error details when `isDev` is enabled. `error.originalError` has a different purpose. > Way too many "required" fields on...

Error Masking incorrectly sets `extensions.originalError` vs `error.originalError`

That's how Error Masking works in GraphQL Yoga. When `isDev` is set, we still apply error masking but show the original error under `extensions` because `GraphQLError`'s `originalError` field is not...

`handleError` incorrectly sets `extensions.http.unexpected` instead of `extensions.unexpected`

Thanks for creating the issue! PRs are welcome for the fix!

Mesh-serve in production

Closing the issue for now. Let us know if you still have any questions or issues. We can always reopen it!