Blaž Hrastnik
Blaž Hrastnik
I kind of like just how simple this change is! It reuses existing UI components and allows exploring the file tree without adding any of the heavier features.
Esc has a binding just like any other key that you can bind to other keys: https://github.com/helix-editor/helix/blob/22a051408a467ff8b3e43457961d5497903dc7d0/helix-term/src/keymap/default.rs#L183 (I also recommend remapping esc to a better place on the keyboard)
simd_json is mostly meant for bulk processing though, we don't parse gigabytes of JSON so it's unlikely that this change is super impactful?
I'm coming from the elixir ecosystem that had a recent push towards [adopting a single telemetry facade across the ecosystem](https://github.com/beam-telemetry/telemetry). It's already been paying off because I can instrument or...
Yeah let's do that, it'll make integration in the UI/JD config possible
We can probably do this in the idle timeout that's also used for completion. Would also be a good place to trigger documentHighlights https://microsoft.github.io/language-server-protocol/specifications/specification-current/#textDocument_documentHighlight
@patrickhuie19 Any idea why the CODEOWNERS check is failing here? There's lots of errors, most of them not caused by this PR
Setting a shorter name will accept the workflow, then fail during workflow execution: ``` "caller":"ocr3/reporting_plugin.go:426","error":"incorrect length for id WorkflowName" ```
It should just use the existing idle-timeout config. That's currently used for completion but the point of it was to set it to a value high enough to trigger only...
Ah cool, I didn't know that would work 👍🏻 Seems like the feature is undocumented, so maybe this issue can be renamed to "document fallback functions"?