chainlink-common icon indicating copy to clipboard operation
chainlink-common copied to clipboard

workflows: Validate workflowName is exactly 10 bytes

Open archseer opened this issue 1 year ago • 2 comments

Current validation allowed shorter names which would then later error in consensus phase

archseer avatar Oct 02 '24 06:10 archseer

@archseer Hmmm... we should be padding the workflow name in consensus to get to 10. What was the error you experienced?

cedric-cordenier avatar Oct 02 '24 09:10 cedric-cordenier

Setting a shorter name will accept the workflow, then fail during workflow execution:

"caller":"ocr3/reporting_plugin.go:426","error":"incorrect length for id WorkflowName"

archseer avatar Oct 02 '24 13:10 archseer

This PR is stale because it has been open 30 days with no activity. Remove the stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jun 15 '25 00:06 github-actions[bot]

This PR has been automatically closed because it has been stale for > 30 days. If you wish to continue working on this PR, please reopen it and make any necessary changes.

github-actions[bot] avatar Jun 24 '25 00:06 github-actions[bot]