Archana Kumari

Results 33 comments of Archana Kumari

I have combine this changes in https://github.com/theforeman/foreman/pull/9926, so marking it as a draft for now.

@ekohl there is one rubocop offense detected that is `Lint/Syntax` https://github.com/theforeman/foreman/actions/runs/9093977252/job/24994075137?pr=10068, even though syntax seems correct to me when i checked the file. Do you mind checking the failure here?

This needs a rebase once https://github.com/theforeman/foreman_monitoring/pull/95 gets merged!

can you take a look @ekohl? i guess, this might need final review.

@ekohl am i missing something here? otherwise I believe it is ready to get in. What is your thought?

I can see one rubocop offense on this cop `Style/SlicingWithRange` which we might have discussed in the past, https://docs.rubocop.org/rubocop/cops_style.html#styleslicingwithrange. Also this is unsafe, but what's your thought on this @ekohl,...

@stejskalleos it is rebased and running on the latest changes. The checks are failing due to some webpack changes, I have looked into it, this seems like some routing issue...

@ekohl i can't find why it is failing clearly, would you please help me here? Edit: Also I guess foreman_default_hostgroup this repo https://github.com/theforeman/foreman_default_hostgroup/pull/62 also has similar kind of failure https://github.com/theforeman/foreman_default_hostgroup/actions/runs/8135910181/job/22231270234?pr=62