foreman_monitoring icon indicating copy to clipboard operation
foreman_monitoring copied to clipboard

Published 20 hours ago • verified publisher icon theforeman

Update RuboCop to 1.23.x and fix various cops

Open archanaserver opened this issue 1 year ago • 4 comments

archanaserver avatar Jan 26 '24 18:01 archanaserver

Please also be specific in which target version you're updating to in Update Rubocop version

ekohl avatar Jan 27 '24 16:01 ekohl

This needs a rebase once https://github.com/theforeman/foreman_monitoring/pull/95 gets merged!

archanaserver avatar Jan 29 '24 13:01 archanaserver

All green now 🍵

archanaserver avatar Feb 22 '24 08:02 archanaserver

can you take a look @ekohl? i guess, this might need final review.

archanaserver avatar Feb 27 '24 12:02 archanaserver

@ekohl am i missing something here? otherwise I believe it is ready to get in. What is your thought?

archanaserver avatar May 09 '24 06:05 archanaserver