Archana Kumari
Archana Kumari
@ekohl does the latest change looks good? then we can move to https://github.com/theforeman/foreman/pull/9982
@ekohl we do want `Layout/ArgumentAlignment` cop fix with `EnforcedStyle: with_fixed_indentation` here?
I'll raise another PR to split up the work for Lint and Style cops to fix.
> I'm not sure why the unit tests fail. Have you taken a look? Yes, this is the error: ``` Error: UsergroupTest#test_0007_should create with valid usergroup: ActiveRecord::RecordInvalid: Validation failed: Name...
@ekohl any thoughts on this one?
@MariaAga, I've noticed there is a webpack failure here. Would you mind taking a look to see what's causing it?
@ekohl what does that mean? "@[archanaserver](https://github.com/archanaserver) archanaserver dismissed [ekohl](https://github.com/ekohl)’s [stale review](https://github.com/theforeman/foreman/pull/9977#pullrequestreview-1824619446) via [38a611e](https://github.com/theforeman/foreman/commit/38a611ed510ff7ef9bf967f290b62ec039cd9976)" edit : and what is stale review? i only reverted my last changes.
@ekohl to pass the redmine check, should I mention same redmine issue number in all commit message or just squash it?
@ekohl done, thanks :)
@ofedoren @ekohl, can you take a look again? i believe it is ready to be merged!