Ambarish Rapte
Ambarish Rapte
I could reproduce this issue. with Latest Openjfx13 build and JDK 12
Looks good to me. Tested on Windows10 and verified that not setting `observer` to `null` does not lead to any leak. Please merge with latest master to trigger a GitHub...
> ```diff > /** > * Start observing the dependencies for changes. If the value of one of the > * dependencies changes, the binding is marked as invalid. >...
Couple quick comments: - Executing the LightingSample manually fails with an exception ``` Caused by: java.lang.NullPointerException: Input stream must not be null at javafx.graphics@23-internal/javafx.scene.image.Image.validateInputStream(Image.java:1140) at javafx.graphics@23-internal/javafx.scene.image.Image.(Image.java:707) at lighting3D.Environment.(Environment.java:64) ``` Steps:...
An observation out of scope of this PR. The effect of lighting on mesh vs a box is quite different. Notice the screenshot, left side is a Box and right...
Looks all good to me. Is it possible to add an automated test ?
I could verify that this change fixes the issue with i3 window manager. Shall do little more testing and update.
Tested a few samples. It looks good. I need sometime (a day or two) to complete code review.
I have tested the patch with several samples. Fix looks good. Though the test fails on my Mac machine with below error. Please verify.. ``` NGNodeDirtyFlagTest > testNGNodesNotDirty FAILED org.junit.ComparisonFailure:...