jfx icon indicating copy to clipboard operation
jfx copied to clipboard

8324233: Update JPEG Image Decoding Software to 9f

Open jayathirthrao opened this issue 1 year ago • 4 comments

IJG has released latest version of libjpeg 9f and we need to update our version also match 9f changes. IJG reference : https://www.ijg.org/

With updated changes both headless and headful tests are green on all platforms.

Also while updating to 9f noticed that many files don't have latest copyright year and comments from previous version updates like 9e, so updated that part also to match 9f version.


Progress

  • [x] Change must not contain extraneous whitespace
  • [x] Commit message must refer to an issue
  • [ ] Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8324233: Update JPEG Image Decoding Software to 9f (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1372/head:pull/1372
$ git checkout pull/1372

Update a local copy of the PR:
$ git checkout pull/1372
$ git pull https://git.openjdk.org/jfx.git pull/1372/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1372

View PR using the GUI difftool:
$ git pr show -t 1372

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1372.diff

Webrev

Link to Webrev Comment

jayathirthrao avatar Feb 20 '24 05:02 jayathirthrao

:wave: Welcome back jdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

bridgekeeper[bot] avatar Feb 20 '24 05:02 bridgekeeper[bot]

Webrevs

mlbridge[bot] avatar Feb 20 '24 06:02 mlbridge[bot]

/reviewers 2

kevinrushforth avatar Feb 21 '24 15:02 kevinrushforth

@kevinrushforth The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

openjdk[bot] avatar Feb 21 '24 15:02 openjdk[bot]

@jayathirthrao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324233: Update JPEG Image Decoding Software to 9f

Reviewed-by: kcr, arapte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 5512a5add0b5ce4a41e6c377c274b9518ee68489: 8326618: Replace usage of deprecated method getId() in Thread
  • d9645730f1e76e95e0bb93ceaeb5550390bf95c1: 8314147: Updated the PhongMaterial documentation
  • df3707d7444c542ba55a8e76a8ed7e8f0637e874: 8320965: Scrolling on a touch enabled display fails on Wayland
  • b43c4edf7590429fd051d1b0e2ccb6dd49a10b8b: 8325550: Grammatical error in AnchorPane.setLeftAnchor (and other setters) javadoc
  • d9263ab268d33104279755dc1de139bd0835fdd7: 8301900: TextArea: Committing text with ENTER in an IME window inserts newline
  • afa206b546a580a784d830712be174bb84f09ee9: 8321603: Bump minimum JDK version for JavaFX to JDK 21
  • e0b88bc7cfede46afe28cbb4a2e333df933b5100: 8278021: Fix warnings in macOS glass native code and treat warnings as errors
  • 9a06bf9c5bce40cf842ddf25fe3360c366c3156c: 8322748: Caret blinking in JavaFX should only stop when caret moves
  • ee8633cb6d19b6da7bf32ad3cdee31261a7cf458: 8089373: Translation from character to key code is not sufficient

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth, @arapte) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk[bot] avatar Feb 29 '24 13:02 openjdk[bot]

/integrate

jayathirthrao avatar Feb 29 '24 13:02 jayathirthrao

@jayathirthrao Your change (at version b43a51e49553da563f83f3fe606c18792f70f30f) is now ready to be sponsored by a Committer.

openjdk[bot] avatar Feb 29 '24 13:02 openjdk[bot]

/sponsor

arapte avatar Feb 29 '24 13:02 arapte

Going to push as commit b99eb45828317e4c195b46eb0c9371d4645f2c6c. Since your change was applied there have been 9 commits pushed to the master branch:

  • 5512a5add0b5ce4a41e6c377c274b9518ee68489: 8326618: Replace usage of deprecated method getId() in Thread
  • d9645730f1e76e95e0bb93ceaeb5550390bf95c1: 8314147: Updated the PhongMaterial documentation
  • df3707d7444c542ba55a8e76a8ed7e8f0637e874: 8320965: Scrolling on a touch enabled display fails on Wayland
  • b43c4edf7590429fd051d1b0e2ccb6dd49a10b8b: 8325550: Grammatical error in AnchorPane.setLeftAnchor (and other setters) javadoc
  • d9263ab268d33104279755dc1de139bd0835fdd7: 8301900: TextArea: Committing text with ENTER in an IME window inserts newline
  • afa206b546a580a784d830712be174bb84f09ee9: 8321603: Bump minimum JDK version for JavaFX to JDK 21
  • e0b88bc7cfede46afe28cbb4a2e333df933b5100: 8278021: Fix warnings in macOS glass native code and treat warnings as errors
  • 9a06bf9c5bce40cf842ddf25fe3360c366c3156c: 8322748: Caret blinking in JavaFX should only stop when caret moves
  • ee8633cb6d19b6da7bf32ad3cdee31261a7cf458: 8089373: Translation from character to key code is not sufficient

Your commit was automatically rebased without conflicts.

openjdk[bot] avatar Feb 29 '24 13:02 openjdk[bot]

@arapte @jayathirthrao Pushed as commit b99eb45828317e4c195b46eb0c9371d4645f2c6c.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk[bot] avatar Feb 29 '24 13:02 openjdk[bot]